refactor: default from address #2271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jia1
reviewed
Aug 8, 2024
KishenKumarrrrr
had a problem deploying
to
staging
GitHub Actions
Failure
jia1
approved these changes
Aug 8, 2024
KishenKumarrrrr
force-pushed
the
refactor/default-from-address
branch
from
9e72054 to
9b58002
Compare
KishenKumarrrrr
force-pushed
the
refactor/default-from-address
branch
from
9b58002 to
69cf50c
Compare
* refactor: modify default from address * fix: bug in from address validation * refactor: reuse isDefaultFromAddress * chore: remove swagger * fix: missing peer dep * fix: move peer dep to fe * chore: move enquirer to dev dep --------- Co-authored-by: KishenKumarrrrr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In this PR, I make changes to the application such that the default mail address is
[email protected]. Since this is a breaking change on the transactional endpoint, we will add an escape hatch to the validation flow such that we will accept both[email protected]and[email protected].This change was made because of a directive by PSD.
Deployment Checklist
BACKEND_SES_FROMtoPostman.gov.sg <[email protected]>WORKER_SES_FROMtoPostman.gov.sg <[email protected]>